From: Junio C Hamano <junkio@cox.net>
Date: Sun, 18 Mar 2007 20:28:58 GMT
Subject: Re: [PATCH 3/5] introduce GIT_WORK_TREE environment variable
Message-ID: <7v4poil2id.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070318202302.GA5191@moooo.ath.cx>

Matthias Lederhofer <matled@gmx.net> writes:

> Matthias Lederhofer <matled@gmx.net> wrote:
>> Matthias Lederhofer <matled@gmx.net> wrote:
>> > +		inside_working_tree = !prefixcmp(cwd, worktree);
>> [..]
>> > +			inside_git_dir = !prefixcmp(cwd, gitdir);
>> 
>> This time a real bug: the parameters have to be the other way around.
>
> Sorry, it was right.  prefixcmp got me confused again when doing some
> testing and the result wasn't what I expected.  I'll go and copy&paste
> 100 times !prefixcmp(str, prefix) means "begins str with prefix?"

I do not mind replacing the whole set, but keeping track of
these small "oops", "oh", "ah" are confusing to me.

Could you take a deep breath, review them yourself one more
time, and resend, *after* making sure that you are confident
with them enough to feel that you would not have to issue
"oops", "sorry", "ah this is better" messages for a few days
after sending them out, pretty please?