git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-send-email: ssh/login style password requests

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 1, 2008, 23:34 UTC
Message-ID
<7v4pcs8d4z.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<5F77BB5B-8D2B-42FD-A805-7195757B14EE@mit.edu>
Michael Witten <mfwitten@MIT.EDU> writes:
> It turns out that --compose will also leave some temporary files
> behind if git-send-email is terminated out of course.
>
> Should I establish a general handler for SIGTERM and SIGINT?

I was mostly worried about ^C leaving the terminal in a funny state with your system(stty).

I do not think you should lose the message the user carefully composed using an editor upon seeing ^C. The user may start to compose, edit the message, and then at some later time decide to stop the mail-sending procedure by ^C-ing out. The user would thank you if you somehow left an escape hatch to allow salvaging the message, instead of having it to be re-typed from scratch.

Previous: Michael WittenNext: Michael Witten
Message 5 of 16 in “git-send-email: ssh/login style password requests”
  1. git-send-email: ssh/login style password requestsMichael Witten, Feb 1, 2008
  2. Junio C HamanoFeb 1, 2008
  3. Michael WittenFeb 1, 2008
  4. Michael WittenFeb 1, 2008
  5. Junio C HamanoFeb 1, 2008
  6. Michael WittenFeb 1, 2008
  7. Junio C HamanoFeb 2, 2008
  8. 1/2 [Perlers?] git-send-email: ssh/login style password requestsMichael Witten, Feb 2, 2008
  9. 2/2 [Perlers?] git-send-email: SIG{TERM,INT} handlersMichael Witten, Feb 2, 2008
  10. Junio C HamanoFeb 2, 2008
  11. Junio C HamanoFeb 2, 2008
  12. Michael WittenFeb 3, 2008
  13. Michael WittenFeb 3, 2008
  14. 1/3 [V.2] git-send-email: ssh/login style password requestsMichael Witten, Feb 4, 2008
  15. 2/3 [V.2] git-send-email: SIG{TERM,INT} handlersMichael Witten, Feb 4, 2008
  16. 3/3 [V.2] git-send-email: Better handling of EOF [^D]Michael Witten, Feb 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.