Michael WittenWhilst convenient, it is most unwise to record passwords in any place but one's brain. Moreover, it is especially foolish to store them in configuration files, even with access permissions set accordingly.
git-send-email has been amended, so that if it detects an smtp username without a password, it promptly prompts for the password and masks the input for privacy.
Furthermore, the argument to --smtp-pass has been rendered optional.
The documentation has been updated to reflect these changes.
Signed-off-by: Michael Witten <mfwitten@mit.edu> ---
This was sent with the updated git-send-email ;-)
Documentation/git-send-email.txt | 19 +++++++++++++++---- git-send-email.perl | 23 +++++++++++++++++++---- 2 files changed, 34 insertions(+), 8 deletions(-)
Show changes to 2 files +34 −7
Documentation/git-send-email.txt, git-send-email.perl
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 0554f2b..6d5abf4 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -96,12 +96,23 @@ The --cc option must be repeated for each user you want on the cc list. servers typically listen to smtp port 25 and ssmtp port 465). ---smtp-user, --smtp-pass:: - Username and password for SMTP-AUTH. Defaults are the values of - the configuration values 'sendemail.smtpuser' and - 'sendemail.smtppass', but see also 'sendemail.identity'. +--smtp-user:: + Username for SMTP-AUTH. The default value can be specified + with the configuration variable 'sendemail.smtpuser' or + sendemail.<identity>.smtpuser (see sendemail.identity). If not set, authentication is not attempted. +--smtp-pass:: + Password for SMTP-AUTH. The default value can be specified + with the configuration variable 'sendemail.smtppass' or + sendemail.<identity>.smtppass (see sendemail.identity). + The argument is optional: If no argument is specified, then + the password is assumed to be the empty string. + If a username has been set, but no password has been set, + the user is prompted for a password with masked input for + privacy; passwords need not be recorded in configuration + files. + --smtp-ssl:: If set, connects to the SMTP server using SSL. Default is the value of the 'sendemail.smtpssl' configuration value; diff --git a/git-send-email.perl b/git-send-email.perl index a1a9d14..ed0a473 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -157,7 +157,7 @@ my $compose_filename = ".msg.$$"; # Variables we fill in automatically, or via prompting: my (@to,@cc,@initial_cc,@bcclist,@xh, - $initial_reply_to,$initial_subject,@files,$author,$sender,$compose,$time); + $initial_reply_to,$initial_subject,@files,$author,$sender,$smtp_authpass,$compose,$time); my $envelope_sender; @@ -177,7 +177,7 @@ my ($quiet, $dry_run) = (0, 0); # Variables with corresponding config settings my ($thread, $chain_reply_to, $suppress_from, $signed_off_cc, $cc_cmd); -my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_authpass, $smtp_ssl); +my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_ssl); my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts); my ($no_validate); @@ -214,7 +214,7 @@ my $rc = GetOptions("sender|from=s" => \$sender, "smtp-server=s" => \$smtp_server, "smtp-server-port=s" => \$smtp_server_port, "smtp-user=s" => \$smtp_authuser, - "smtp-pass=s" => \$smtp_authpass, + "smtp-pass:s" => \$smtp_authpass, "smtp-ssl!" => \$smtp_ssl, "identity=s" => \$identity, "compose" => \$compose, @@ -647,9 +647,24 @@ X-Mailer: git-send-email $gitversion die "Unable to initialize SMTP properly. Is there something wrong with your config?"; } - if ((defined $smtp_authuser) && (defined $smtp_authpass)) { + if (defined $smtp_authuser) { + + if (!defined $smtp_authpass) { + + system "stty -echo"; + + do { + $_ = $term->readline("Password: "); + } while (!defined $_); + + system "stty echo"; + + $smtp_authpass = $_ if ($_); + } + $auth ||= $smtp->auth( $smtp_authuser, $smtp_authpass ) or die $smtp->message; } + $smtp->mail( $raw_from ) or die $smtp->message; $smtp->to( @recipients ) or die $smtp->message; $smtp->data or die $smtp->message;
-- 1.5.4.rc5.17.g536ee
