git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/3] bisect: use a detached HEAD to bisect

From
Junio C Hamano <gitster@pobox.com>
Date
May 26, 2008, 01:11 UTC
Message-ID
<7v4p8lhnt1.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<18490.280.325614.480038@cargo.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> writes:
Show 33 quoted lines
> Linus Torvalds writes:
>
>> Of course, _usually_ it's just the top commit, and it's obvious that way 
>> which one is the checked-out one, but if you do "gitk --all" or just 
>> generally have multiple branches, right now it's hard to see what commit 
>> is the checked-out one, regardless of whether it's detached or not.
>
> If it's not detached, the branch name is in bold, but evidently that's
> either not intuitive or not sufficiently distinct...
>
>> I think "HEAD" in a green box would solve that too, but on the other hand, 
>> we have a *lot* of boxes already. For people who mainly just track another 
>> repo, you already have one box saying "master", and another one saying 
>> "remotes/origin/master", and adding yet *another* box saying HEAD that 
>> just points to the same commit will work, but do we really want that?
>> 
>> I actually like the red circle for "Local uncommitted changes". Maybe we 
>> can use a similar visual clue for "currently checked out". You already 
>> picked green for the "added to the index" case, so we have the three 
>> primary RGB colors already used, but we could make it just be a deep 
>> yellow.
>> 
>> Of course, maybe people hate lots of colos already, and something more 
>> akin to the text background thing that we use for the selected commit 
>> would be better.
>> 
>> I dunno. There's so many options.
>> 
>> Here's a "make it yellow" patch.
>
> Thanks.  I have checked in something similar, that also handles the
> cases where you update the graph and the head has moved, and when you
> do a checkout or reset using the gitk menus.

Thanks. Will pull, but it will have to miss upcoming 1.5.6-rc0, unfortunately.

Previous: Paul Mackerras
Message 10 of 10 in “bisect: use a detached HEAD to bisect”
  1. 4/3 bisect: use a detached HEAD to bisectChristian Couder, May 22, 2008
  2. Junio C HamanoMay 23, 2008
  3. Christian CouderMay 23, 2008
  4. Jon LoeligerMay 23, 2008
  5. Linus TorvaldsMay 23, 2008
  6. Paul MackerrasMay 24, 2008
  7. Linus TorvaldsMay 24, 2008
  8. Jeff KingMay 25, 2008
  9. Paul MackerrasMay 26, 2008
  10. Junio C HamanoMay 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.