Re: [PATCH 4/3] bisect: use a detached HEAD to bisect

From: Jon Loeliger <jdl@freescale.com>
Date: May 23, 2008, 15:14 UTC
Message-ID: <4836DF69.4060609@freescale.com>
In-Reply-To: <7v3ao9twfa.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 14 quoted lines

> Christian Couder <chriscool@tuxfamily.org> writes:
> 
>> When "git bisect" was first written, it was not possible to
>> checkout a detached HEAD. The detached feature appeared latter.
>> ...
>> This patch makes "git bisect" checkout revisions to be tested on
>> a detached HEAD. This simplifies the code a bit.
> 
> Yay!!
> 
> One potential worry/downside is "bisect visualize".  Because <bisect>
> branch was used for bisection, the _current_ commit has always been
> indicated with a label.  HEAD would not get any special label in gitk,
> would it?

Hrm. This seems like a potential issue to me as I occasionally do want to view where it is and possibly adjust it up or down a few commits depending on context.

Perhaps a "git bisect addfoo" sort of command is needed? The goal would be to "add some form of {branch,label,tag}" so it could be named, seen and possibly moved.

jdl