Re: [PATCH RFC 2/2] gitweb: Hyperlink multiple git hashes on the same commit message line
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 20, 2009, 08:35 UTC
- Message-ID
- <7v4oypfqua.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <200902182255.13983.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 8 quoted lines
>> + $line =~ s{\b([0-9a-fA-F]{8,40})\b}{
>> + return $cgi->a({-href => href(action=>"object", hash=>$1),
>> + -class => "text"}, $1);
>> + }eg;
>> +
>
> Almost correct... but for this unnecessary 'return' statement.
> Without it: ACK.I've applied this directly on 'master' without the return from inside s///e with your Ack. Please check the result.
Thanks.