Re: [PATCH RFC 2/2] gitweb: Hyperlink multiple git hashes on the same commit message line

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 20, 2009, 11:46 UTC
Message-ID: <200902201247.00670.jnareb@gmail.com>
In-Reply-To: <7v4oypfqua.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 13 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
> >> +	$line =~ s{\b([0-9a-fA-F]{8,40})\b}{
> >> +		return $cgi->a({-href => href(action=>"object", hash=>$1),
> >> +					   -class => "text"}, $1);
> >> +	}eg;
> >> +
> >
> > Almost correct... but for this unnecessary 'return' statement.
> > Without it: ACK.
> 
> I've applied this directly on 'master' without the return from inside s///e
> with your Ack.  Please check the result.

I did quick test by installing newest gitweb (with above commit applied), doing in gitweb searching commit message for '[a-f0-9]{8,40}' with regexp search; everything looks all right. But I didn't do extensive tests.

-- 
Jakub Narebski
Poland