Re: [PATCH] Reserve a slot for argv[0] in default_arg.

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 4, 2009, 22:20 UTC
Message-ID: <7v4oqen6my.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091004182746.GA22995@coredump.intra.peff.net>

Stephen Boyd <bebarino@gmail.com> writes:

Show 8 quoted lines

> On Sun, 2009-10-04 at 14:27 -0400, Jeff King wrote:
>> 
>> Ah, thanks, for some reason I wasn't able to produce it before, but I
>> can easily replicate it here. I think it's a regression from converting
>> show-branch to use parse_options, which happened in May, but I didn't
>> actually bisect it. I'm not sure showbranch.default has worked at all
>> since then (which I guess goes to show how many people are actually
>> using it).

It is a command specific aliasing mechanism; not even I use the feature these days, since "alias.*" is much easier to use. But there is no strong need to remove it either; it is not too much hassle to keep it for people who do use it. Perhaps deprecate it and remove it in the long run?

Show 5 quoted lines

> Correct. Junio sent a patch to fix this problem in June[1]. I guess he
> must have dropped his own patch, or he wasn't satisfied with how parse
> options clobbers things.
>
> [1] http://article.gmane.org/gmane.comp.version-control.git/121142

I had it kept still in my Inbox; thanks for noticing. Petter's patch does essentially the same thing, but the old patch had a better log message that described where in the history the fix should apply, so I'd probably use that with your test squashed in.

Thanks.