Re: [PATCH] Reserve a slot for argv[0] in default_arg.

From: Jeff King <peff@peff.net>
Date: Oct 5, 2009, 18:45 UTC
Message-ID: <20091005184532.GA20078@coredump.intra.peff.net>
In-Reply-To: <20091005063649.GA25040@eideticdew.org>

On Mon, Oct 05, 2009 at 08:36:49AM +0200, Petter Urkedal wrote:

Show 7 quoted lines

> On 2009-10-04, Junio C Hamano wrote:
> > It is a command specific aliasing mechanism; not even I use the feature
> > these days, since "alias.*" is much easier to use.  But there is no strong
> > need to remove it either; it is not too much hassle to keep it for people
> > who do use it.  Perhaps deprecate it and remove it in the long run?
> 
> I didn't know about alias.*.  Excellent.  I'll be using that.

Yeah, showbranch.default really seems pointless now. Especially confusing is the fact that it doesn't do whitespace-splitting, so you can't do:

  git config showbranch.default "--topo-order branch1 branch2"

but instead have to set multiple config variables.

I think deprecation makes sense, but I am in no hurry to get rid of it. I mainly just wouldn't want people to think it was a useful thing to learn. :)

> The code is slightly nicer to, I think, but you can probably drop "+ 20"
> in the grow-case now.

I think it could actually just be switched to use ALLOC_GROW.

-Peff