Re: [PATCH v5 05/18] Do not use "diff" found on PATH while building and installing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 2, 2010, 04:39 UTC
- Message-ID
- <7v4ohmqc93.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20100514093746.689775000@mlists.thewrittenword.com>
"Gary V. Vaughan" <git@mlists.thewrittenword.com> writes:
Show 10 quoted lines
> Index: b/Documentation/install-webdoc.sh > =================================================================== > --- a/Documentation/install-webdoc.sh > +++ b/Documentation/install-webdoc.sh > @@ -12,7 +12,7 @@ do > then > : did not match > elif test -f "$T/$h" && > - diff -u -I'Last updated [0-9][0-9]-[A-Z][a-z][a-z]-' "$T/$h" "$h" > + $DIFF -u -I'Last updated [0-9][0-9]-[A-Z][a-z][a-z]-' "$T/$h" "$h"
Do we or do we not want to quote "$DIFF"? iow, how well do we deal with $IFS whitespace in the path?