Re: [PATCH] git-compat-util.h: use apparently more common __sgi macro to detect SGI IRIX

From: Gary V. Vaughan <git@mlists.thewrittenword.com>
Date: Jun 2, 2010, 08:43 UTC
Message-ID: <20100602084331.GA1782@thor.il.thewrittenword.com>
In-Reply-To: <4gJWLBIdRVtK7gq22o-LadCixyvOA-9FlEvk-ZrCHyUsGwArvR9oPkV-qlez-T-Nsn0v6UO633Y@cipher.nrlssc.navy.mil>

Hi Brandon,

On Tue, Jun 01, 2010 at 08:55:36PM -0500, Brandon Casey wrote:

Show 8 quoted lines

> From: Gary V. Vaughan <git@mlists.thewrittenword.com>
> 
> IRIX 6.5.26m does not define the 'sgi' macro, but it does define an '__sgi'
> macro.  Since later IRIX versions (6.5.29m) define both macros, and since
> an underscore prefixed macro is preferred anyway, use '__sgi' to detect
> compilation on SGI IRIX.
> 
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>

Signed-off-by: Gary V. Vaughan <gary@thewrittenword.com>

Show 5 quoted lines

> Here's a resubmit of your patch with an updated commit message.  Since the
> __sgi macro seems to be more common than the sgi macro, I modified your
> patch to check for only the __sgi macro.  I know Junio suggested checking
> for both macros, but I'm the one that Junio was talking about when he made
> his comments, and __sgi works for me.

Sure, that's fine. I only need the __sgi part for git to compile correctly on my IRIX machines, so if you feel that the non-underscore flavour is superfluous then I won't miss it! ;)

> It's such a simple little patch, but still I removed your signed-off-by line
> since I modified the patch, and I am not you.  Please do reply to this message
> with a signed-off-by if you sign off on the patch.  Junio will add it to the
> patch when he applies the it.

Done.

Cheers,

-- 
Gary V. Vaughan (gary@thewrittenword.com)