Re: [PATCH] tests: fix overeager scrubbing of environment variables

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 28, 2011, 17:00 UTC
Message-ID: <7v4o6n18oy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110327213756.GD25927@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 21 quoted lines

> Jens Lehmann wrote:
>
>> - GIT_SKIP_TESTS
>> - GIT_TEST*
>> - GIT_PROVE_OPTS
>>
>> Let's fix that by adding them to the exception list.
>>
>> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
>
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
>
> It misses a few, though:
>
>  - GIT_REMOTE_SVN_TEST_BIG_FILES
>  - GIT_NOTES_TIMING_TESTS
>  - GIT_PATCHID_TIMING_TESTS
>  - GIT_VALGRIND_OPTIONS
>
> If we were starting over I suppose those would all be GIT_TEST* but
> there's something to be said for muscle memory.

I don't think muscle memory matters as much in this case as the usual end-user facing interfaces. These are only for people who build and test git, not for our end users.

I think it is Ok to do this (yes I am trying to avoid doing this myself, as I am a bit behind and also am lazy) just as a single patch to rename the environment variables, and filter them with a single GIT_TEST_* pattern at the same time.

Thanks.