Re: [PATCH] tests: fix overeager scrubbing of environment variables

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 27, 2011, 21:37 UTC
Message-ID: <20110327213756.GD25927@elie>
In-Reply-To: <4D8FAAAC.3050905@web.de>

Jens Lehmann wrote:

Show 7 quoted lines

> - GIT_SKIP_TESTS
> - GIT_TEST*
> - GIT_PROVE_OPTS
>
> Let's fix that by adding them to the exception list.
>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>

Acked-by: Jonathan Nieder <jrnieder@gmail.com>

It misses a few, though:

 - GIT_REMOTE_SVN_TEST_BIG_FILES
 - GIT_NOTES_TIMING_TESTS
 - GIT_PATCHID_TIMING_TESTS
 - GIT_VALGRIND_OPTIONS

If we were starting over I suppose those would all be GIT_TEST* but there's something to be said for muscle memory.

Show 5 quoted lines

> I noticed today that skipping a test the way I was used to suddenly failed:
>
> GIT_SKIP_TESTS='t1234' GIT_TEST_OPTS='--root=/dev/shm' make -j10 test
>
> This should work according to t/README, but didn't anymore.

I would have just written that in the change description.

Good catch, thanks.