Re: [PATCH] reset: update help text

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 31, 2011, 18:45 UTC
Message-ID: <7v4o6jku28.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110329210457.GA14031@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 18 quoted lines

> The description does not make it obvious to me how these two (--merge
> and --keep) differ.  I think the intent of the options are:
>
>  --keep:
> 	start working on a different commit, carrying over local changes
> 	(like "git checkout")
>  --merge:
> 	return to <commit>, cancelling a merge-like operation that
> 	creates some unmerged and some clean index entries
>
> Maybe something along these lines could be ok starting point?
>
> 	OPT_SET_INT(0, "keep", &reset_type,
> 		"move to <commit>, carrying over local changes in working tree",
> 		KEEP),
> 	OPT_SET_INT(0, "merge", &reset_type,
> 		"return to <commit>, cancelling failed merge or cherry-pick",
> 		MERGE),

I cannot think of anything better, but I can still show my concern that "move to" and "return to" might not convey exactly what we are trying to express.

But I agree that your phrasing definitely is a good starting point.