git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Probable bug in file run-command.c function clear_child_for_cleanup

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 10, 2012, 20:12 UTC
Message-ID
<7v4nn5ocvv.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120910200110.GA32437@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 14 quoted lines
> On Mon, Sep 10, 2012 at 01:00:35PM -0700, Junio C Hamano wrote:
>
>> >> And to conclude my bikeshedding for the day: Shouldn't "last" ideally
>> >> be called something like "prev" instead? It's the previously visited
>> >> element, not the last element in the list.
>> >
>> > It is the "last" element visited (just as "last week" is not the end of
>> > the world), but yes, it is ambiguous, and "prev" is not. Either is fine
>> > by me.
>> 
>> OK, so who's gonna do the honors?
>
> I was hoping to give David a chance to submit his first-ever patch to
> git.

OK. David, is it OK for us to expect a patch from you sometime not in distant future (it is an old bug we survived for a long time and nothing ultra-urgent)?

Previous: Jeff KingNext: David Gould
Message 7 of 8 in “Probable bug in file run-command.c function clear_child_for_cleanup”
  1. David GouldSep 9, 2012
  2. Jeff KingSep 10, 2012
  3. Erik Faye-LundSep 10, 2012
  4. Jeff KingSep 10, 2012
  5. Junio C HamanoSep 10, 2012
  6. Jeff KingSep 10, 2012
  7. Junio C HamanoSep 10, 2012
  8. David GouldSep 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.