From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Sep 2012 20:12:52 GMT
Subject: Re: Probable bug in file run-command.c function clear_child_for_cleanup
Message-ID: <7v4nn5ocvv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120910200110.GA32437@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Sep 10, 2012 at 01:00:35PM -0700, Junio C Hamano wrote:
>
>> >> And to conclude my bikeshedding for the day: Shouldn't "last" ideally
>> >> be called something like "prev" instead? It's the previously visited
>> >> element, not the last element in the list.
>> >
>> > It is the "last" element visited (just as "last week" is not the end of
>> > the world), but yes, it is ambiguous, and "prev" is not. Either is fine
>> > by me.
>> 
>> OK, so who's gonna do the honors?
>
> I was hoping to give David a chance to submit his first-ever patch to
> git.

OK. David, is it OK for us to expect a patch from you sometime not
in distant future (it is an old bug we survived for a long time and
nothing ultra-urgent)?