git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] run-command: use thread-aware die_is_recursing routine

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 16, 2013, 22:09 UTC
Message-ID
<7v4nf6jfg7.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130416195006.GB11185@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 37 quoted lines
> diff --git a/run-command.c b/run-command.c
> index 765c2ce..1b32a12 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -588,6 +588,7 @@ static pthread_key_t async_key;
>  static pthread_t main_thread;
>  static int main_thread_set;
>  static pthread_key_t async_key;
> +static pthread_key_t async_die_counter;
>  
>  static void *run_thread(void *data)
>  {
> @@ -614,6 +615,14 @@ static NORETURN void die_async(const char *err, va_list params)
>  
>  	exit(128);
>  }
> +
> +static int async_die_is_recursing(void)
> +{
> +	void *ret = pthread_getspecific(async_die_counter);
> +	pthread_setspecific(async_die_counter, (void *)1);
> +	return ret != NULL;
> +}
> +
>  #endif
>  
>  int start_async(struct async *async)
> @@ -695,7 +704,9 @@ int start_async(struct async *async)
>  		main_thread_set = 1;
>  		main_thread = pthread_self();
>  		pthread_key_create(&async_key, NULL);
> +		pthread_key_create(&async_die_counter, NULL);
>  		set_die_routine(die_async);
> +		set_die_is_recursing_routine(async_die_is_recursing);
>  	}
>  
>  	if (proc_in >= 0)
Will queue; thanks.
Previous: Jeff KingNext: Jonathan Nieder
Message 16 of 23 in “avoid bogus "recursion detected in die handler" message”
  1. 0/3 avoid bogus "recursion detected in die handler" messageJeff King, Apr 15, 2013
  2. 1/3 usage: refactor die-recursion checksJeff King, Apr 15, 2013
  3. Eric SunshineApr 15, 2013
  4. Jeff KingApr 15, 2013
  5. Brandon CaseyApr 16, 2013
  6. Jeff KingApr 16, 2013
  7. Jonathan NiederApr 16, 2013
  8. Brandon CaseyApr 16, 2013
  9. Jeff KingApr 16, 2013
  10. Johannes SixtApr 16, 2013
  11. Jeff KingApr 16, 2013
  12. Johannes SixtApr 16, 2013
  13. 0/2 avoid bogus "recursion detected in die handler" messageJeff King, Apr 16, 2013
  14. 1/2 usage: allow pluggable die-recursion checksJeff King, Apr 16, 2013
  15. 2/2 run-command: use thread-aware die_is_recursing routineJeff King, Apr 16, 2013
  16. Junio C HamanoApr 16, 2013
  17. Jonathan NiederApr 17, 2013
  18. Jeff KingApr 17, 2013
  19. Erik Faye-LundApr 23, 2013
  20. 2/3 run-command: factor out running_main_thread functionJeff King, Apr 15, 2013
  21. Jonathan NiederApr 16, 2013
  22. Jeff KingApr 16, 2013
  23. 3/3 usage: do not check die recursion outside main threadJeff King, Apr 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.