git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] usage: refactor die-recursion checks

From
Jeff King <peff@peff.net>
Date
Apr 15, 2013, 23:47 UTC
Message-ID
<20130415234725.GA8031@sigill.intra.peff.net>
In-Reply-To
<CAPig+cQtXO_jvymrT1Y69W+bhJ908o3HNABj1eVLN5zdJtpT+Q@mail.gmail.com>
On Mon, Apr 15, 2013 at 07:45:03PM -0400, Eric Sunshine wrote:
Show 6 quoted lines
> On Mon, Apr 15, 2013 at 7:08 PM, Jeff King <peff@peff.net> wrote:
> > This patch teaches die() to print the original die message
> > to stderr before reporting the recursion. The custom
> > die_routine may or may not have put it the message to
> 
> s/put it the/emitted/ perhaps?

I meant s/ it//, but I think "sent the message to..." is probably more clear.

Show 11 quoted lines
> > stderr, but this is the best we can do (it is what most
> > handlers will do anyway, and it is where our recursion error
> > will go).
> >
> > While we're at it, let's mark the "recursion detected"
> > message as a "BUG:", since it should never happen in
> > practice. And let's factor out the repeated code in die and
> > die_errno. This loses the information of which function was
> > called to cause the recursion, but it's important; knowing
> 
> Was this supposed to be s/important/unimportant/?

Urgh, yes, it was originally "not important" but I lost the "not" while trying to clarify the wording.

Thanks.
-Peff
Previous: Eric SunshineNext: Brandon Casey
Message 4 of 23 in “avoid bogus "recursion detected in die handler" message”
  1. 0/3 avoid bogus "recursion detected in die handler" messageJeff King, Apr 15, 2013
  2. 1/3 usage: refactor die-recursion checksJeff King, Apr 15, 2013
  3. Eric SunshineApr 15, 2013
  4. Jeff KingApr 15, 2013
  5. Brandon CaseyApr 16, 2013
  6. Jeff KingApr 16, 2013
  7. Jonathan NiederApr 16, 2013
  8. Brandon CaseyApr 16, 2013
  9. Jeff KingApr 16, 2013
  10. Johannes SixtApr 16, 2013
  11. Jeff KingApr 16, 2013
  12. Johannes SixtApr 16, 2013
  13. 0/2 avoid bogus "recursion detected in die handler" messageJeff King, Apr 16, 2013
  14. 1/2 usage: allow pluggable die-recursion checksJeff King, Apr 16, 2013
  15. 2/2 run-command: use thread-aware die_is_recursing routineJeff King, Apr 16, 2013
  16. Junio C HamanoApr 16, 2013
  17. Jonathan NiederApr 17, 2013
  18. Jeff KingApr 17, 2013
  19. Erik Faye-LundApr 23, 2013
  20. 2/3 run-command: factor out running_main_thread functionJeff King, Apr 15, 2013
  21. Jonathan NiederApr 16, 2013
  22. Jeff KingApr 16, 2013
  23. 3/3 usage: do not check die recursion outside main threadJeff King, Apr 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.