Re: [PATCH 4/4] Replace fork_with_pipe in bundle with run_command

From: Junio C Hamano <junkio@cox.net>
Date: Mar 13, 2007, 00:54 UTC
Message-ID: <7v3b4aotd9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070313003646.GA17169@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

Show 14 quoted lines

> Junio C Hamano <junkio@cox.net> wrote:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>> >  	return status;
>> 
>> As the variable 'status' is not used anymore, I think this should return 0.
>
> Indeed.  I replaced that patch with another (same subject) in my
> latest series.  Because leaving that 'status' variable in caused
> a failure in the test suite when trying to create a bundle.
>
>   fixed:  http://article.gmane.org/gmane.comp.version-control.git/42087
>   borked: http://article.gmane.org/gmane.comp.version-control.git/42056
>
> You quoted the borked one.  Please drop it and apply the fixed one.

Ok, diffing these two the only differences I see are identical to what I locally hand-fixed, so we are Ok it seems.