Re: [PATCH 4/4] Replace fork_with_pipe in bundle with run_command

From: Shawn O. Pearce <spearce@spearce.org>
Date: Mar 13, 2007, 00:36 UTC
Message-ID: <20070313003646.GA17169@spearce.org>
In-Reply-To: <7vslcaow13.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> >  	return status;
> 
> As the variable 'status' is not used anymore, I think this should return 0.

Indeed. I replaced that patch with another (same subject) in my latest series. Because leaving that 'status' variable in caused a failure in the test suite when trying to create a bundle.

  fixed:  http://article.gmane.org/gmane.comp.version-control.git/42087
  borked: http://article.gmane.org/gmane.comp.version-control.git/42056

You quoted the borked one.  Please drop it and apply the fixed one.

-- 
Shawn.