Re: [PATCH v3 1/2] git-am: emit usage when called w/o arguments and w/o patch on stdin

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2009, 18:15 UTC
Message-ID: <7v3af3thyj.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <76718490901280840g7d36aa96u3d0f98a709ac9fde@mail.gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

Show 7 quoted lines

> On Wed, Jan 28, 2009 at 11:18 AM, Pieter de Bie <pdebie@ai.rug.nl> wrote:
>> FWIW, I sometimes like to run 'git am', paste in a patch and hit ctrl-d.
>>
>> I can probably retrain my finger to use 'git am -', but I'm not sure if that
>> works (after this patch)? At least it's not mentioned in the manpage.
>
> "git am -" doesn't work (before or after this patch), but "cat | git am" will.

Another approach we've taken in other places to avoid the "Huh?" that triggered this thread is to do something like:

        if there is no argument
        then
		if reading from tty
	        then
	        	echo >&2 "Reading from terminal, waiting for input..."
		fi
                process stdin	
	else
        	for arg
                do
                	process $arg
		done
	fi

Unfortunately, this will invalidate your "check -t 0 and error out" patch, but some people may find it easier to work with and more friendly.