Re: [PATCH v3 1/2] git-am: emit usage when called w/o arguments and w/o patch on stdin

From: Jay Soffian <jaysoffian@gmail.com>
Date: Jan 28, 2009, 18:26 UTC
Message-ID: <76718490901281026i45c26cb0r978f795a50dede19@mail.gmail.com>
In-Reply-To: <7v3af3thyj.fsf@gitster.siamese.dyndns.org>

On Wed, Jan 28, 2009 at 1:15 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

> Another approach we've taken in other places to avoid the "Huh?" that
> triggered this thread is to do something like:
>
>        if there is no argument
>        then
>                if reading from tty
>                then
>                        echo >&2 "Reading from terminal, waiting for input..."
>                fi
>                process stdin
>        else
>                for arg
>                do
>                        process $arg
>                done
>        fi
>
> Unfortunately, this will invalidate your "check -t 0 and error out" patch,
> but some people may find it easier to work with and more friendly.

Well perhaps we should just deal w/ctrl-c only and ignore the terminal check altogether.

j.