Re: [PATCH] gitk: disable checkout of remote branch

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 21, 2009, 09:22 UTC
Message-ID: <7v3a9uszzl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <slrnh3ru9v.vgo.sitaramc@sitaramc.homelinux.net>

Sitaram Chamarty <sitaramc@gmail.com> writes:

Show 8 quoted lines

> At the command line, this gives you a detailed warning message, but the
> GUI currently allows it without any fuss.
>
> Since the GUI is often used by people much less familiar with git, it
> seems reasonable to make the GUI more restrictive than the command line,
> not less.
> ...
> This patch helps me a lot.

The patch seems to disable checkout unconditionally, but it at least needs an "expert mode" switch to bypass the patch's logic, or (better yet) a "training wheel" switch for you to set in repositories of the people you manage.

Show 6 quoted lines

> diff --git a/gitk-git/gitk b/gitk-git/gitk
> old mode 100644
> new mode 100755
> index 8c66d17..411bc52
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk

The above should ideally read:

> diff --git a/gitk b/gitk
> index 8c66d17..411bc52
> --- a/gitk
> +++ b/gitk

if the patch goes to Paulus.

Show 12 quoted lines

> @@ -8770,6 +8770,9 @@ proc headmenu {x y id head} {
>      set headmenuid $id
>      set headmenuhead $head
>      set state normal
> +    if {[string match "remotes/*" $head]} {
> +	set state disabled
> +    }
>      if {$head eq $mainhead} {
>  	set state disabled
>      }
> -- 
> 1.6.3.2