[PATCH] gitk: disable checkout of remote branch

From: Sitaram Chamarty <sitaramc@gmail.com>
Date: Jun 22, 2009, 03:42 UTC
Message-ID: <2e24e5b90906212042l3182b634y2a51efb645e4bcf@mail.gmail.com>
In-Reply-To: <7vtz29p3qm.fsf@alter.siamese.dyndns.org>

At the command line, this gives you a detailed warning message, but the GUI currently allows it without any fuss.

Since the GUI is often used by people much less familiar with git, it seems reasonable to make the GUI more restrictive than the command line, not less.

This prevents a lot of detached HEAD commits by new users.

Signed-off-by: Sitaram Chamarty <sitaramc@gmail.com>
---

Paul,

I have amended the diff header to fit the gitk repo as opposed to the git repo. To summarise the email discussions, the feature that is being disabled gets you a detached HEAD, but if that were really the intent we should allow a detached HEAD from any commit, not just a head commit. Therefore this particular disablement is useful and makes the GUI experience safer.

Please accept.  Thanks.

 gitk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gitk b/gitk
index 4604c83..70b6abc 100755
--- a/gitk
+++ b/gitk
@@ -8833,6 +8833,9 @@ proc headmenu {x y id head} {
     set headmenuid $id
     set headmenuhead $head
     set state normal
+    if {[string match "remotes/*" $head]} {
+	set state disabled
+    }
     if {$head eq $mainhead} {
 	set state disabled
     }

-- 
1.6.3.2