Re: [PATCH] grep: do not do external grep on skip-worktree entries

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 3, 2010, 20:49 UTC
Message-ID: <7v3a2mzzg4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.2.00.1001031124420.3630@localhost.localdomain>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 5 quoted lines

> Which means that if you put /usr/xpg4/bin before other paths in your PATH, 
> you'll totally break such systems, because now you get the (inferior) 
> tools in xpg4 before the preferred tools in /usr/local. Or - this also 
> happens - people end up installing their own versions in $HOME/bin, 
> because the system admin is uncaring or incompetent.

The build allows you to define SANE_TOOL_PATH ("the tools found in here are saner than the ones in /usr/bin or /bin" is what it means) and we insert it just in front of /usr/bin or /bin in the original PATH (see git_brokne_path_fix in git-sh-setup.sh).

I would call this the right thing (TM) or the best workaround we could do under the constraints, depending on the mood.