Re: [PATCH] grep: do not do external grep on skip-worktree entries

From: Fredrik Kuivinen <frekui@gmail.com>
Date: Jan 11, 2010, 19:40 UTC
Message-ID: <4c8ef71001111140j7e7d0081o7718d956104a2451@mail.gmail.com>
In-Reply-To: <alpine.LFD.2.00.1001111124480.17145@localhost.localdomain>

On Mon, Jan 11, 2010 at 20:29, Linus Torvalds <torvalds@linux-foundation.org> wrote:

Show 11 quoted lines

>
>
> On Mon, 11 Jan 2010, Fredrik Kuivinen wrote:
>>
>> Any ideas on how this can be explained?
>
> Could it be a bad 'strstr()' implementation?
>
> Try a complex pattern ("qwerty.*as" finds the same line), and see if that
> too is slower than before. If that is faster than it used to be (with
> --no-ext-grep, of course), then it's strstr() that is badly implemented.

Ah, yes, that's it. With the pattern "qwerty.*as" I get 2.5s with the patch and 6s without.

Thanks.

- Fredrik

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.