git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fwd: [PATCH 2/2] pretty.c: allow date formats in user format strings

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 9, 2011, 21:06 UTC
Message-ID
<7v39mw9f7a.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110307161758.GB11934@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> So I think the whole thing needs to be factored into two phases: a
> parsing phase where we build some internal parse tree, and then an
> expansion phase where we walk the parse tree for each commit (or ref, or
> whatever is being expanded).

You are right. I think for-each-ref expander has an attempt for optimization of this exact kind.

Show 8 quoted lines
>> Point is: we're going to keep having more and more format options,
>> I think that's a given. At some point, these short mnemonics will just
>> stop making sense, and it makes sense to have an escape plan when
>> that happens.
>
> Agreed. And I think it is possible to do it in a backwards-compatible
> way; support %(longname:options) for everything, and keep short-hands
> like %h and %ad for existing elements without options.

Yes, I think %( is not taken in the pretty-format language, so we should be able to do this.

I wanted to take your earlier "'%ad' or '%ad(format)'" patch but refrained from doing so. The above line of reasoning is much better for the long term health of the project.

Previous: Will PalmerNext: Jeff King
Message 13 of 15 in “[Bug] %[a|c]d placeholder does not respect --date= option in combination with git archive”
  1. Dietmar WinklerMar 3, 2011
  2. Jeff KingMar 3, 2011
  3. Dietmar WinklerMar 4, 2011
  4. Jeff KingMar 5, 2011
  5. 1/2 pretty.c: give format_person_part the whole placeholderJeff King, Mar 5, 2011
  6. 2/2 pretty.c: allow date formats in user format stringsJeff King, Mar 5, 2011
  7. Fwd: [PATCH 2/2] pretty.c: allow date formats in user format stringsWill Palmer, Mar 6, 2011
  8. Jeff KingMar 7, 2011
  9. Will PalmerMar 7, 2011
  10. Will PalmerMar 7, 2011
  11. Jeff KingMar 7, 2011
  12. Will PalmerMar 8, 2011
  13. Junio C HamanoMar 9, 2011
  14. Jeff KingMar 10, 2011
  15. Dietmar WinklerMar 11, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.