git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fwd: [PATCH 2/2] pretty.c: allow date formats in user format strings

From
Jeff King <peff@peff.net>
Date
Mar 10, 2011, 22:31 UTC
Message-ID
<20110310223148.GD15828@sigill.intra.peff.net>
In-Reply-To
<7v39mw9f7a.fsf@alter.siamese.dyndns.org>
On Wed, Mar 09, 2011 at 01:06:17PM -0800, Junio C Hamano wrote:
Show 10 quoted lines
> > Agreed. And I think it is possible to do it in a backwards-compatible
> > way; support %(longname:options) for everything, and keep short-hands
> > like %h and %ad for existing elements without options.
> 
> Yes, I think %( is not taken in the pretty-format language, so we should
> be able to do this.
> 
> I wanted to take your earlier "'%ad' or '%ad(format)'" patch but refrained
> from doing so.  The above line of reasoning is much better for the long
> term health of the project.

OK. Do you want me to throw away the %ad(format) patch for now, then, in favor of building it on top of a more sane syntax?

I had originally planned to do %ad(format) for now, and then worry about syntax later. Since we already have a variety of of other placeholders with similar syntax (e.g., %w(), %C()). But I don't care too much either way; it is not a feature I personally wanted, so delay doesn't bother me. Dietmar (the original requestor) may feel differently, of course. :)

-Peff
Previous: Junio C HamanoNext: Dietmar Winkler
Message 14 of 15 in “[Bug] %[a|c]d placeholder does not respect --date= option in combination with git archive”
  1. Dietmar WinklerMar 3, 2011
  2. Jeff KingMar 3, 2011
  3. Dietmar WinklerMar 4, 2011
  4. Jeff KingMar 5, 2011
  5. 1/2 pretty.c: give format_person_part the whole placeholderJeff King, Mar 5, 2011
  6. 2/2 pretty.c: allow date formats in user format stringsJeff King, Mar 5, 2011
  7. Fwd: [PATCH 2/2] pretty.c: allow date formats in user format stringsWill Palmer, Mar 6, 2011
  8. Jeff KingMar 7, 2011
  9. Will PalmerMar 7, 2011
  10. Will PalmerMar 7, 2011
  11. Jeff KingMar 7, 2011
  12. Will PalmerMar 8, 2011
  13. Junio C HamanoMar 9, 2011
  14. Jeff KingMar 10, 2011
  15. Dietmar WinklerMar 11, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.