Re: [PATCH] Do not allow refnames to start with a slash

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2011, 18:17 UTC
Message-ID: <7v39gpmk3x.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1314259695-30801-1-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

Show 8 quoted lines

> diff --git a/t/t1402-check-ref-format.sh b/t/t1402-check-ref-format.sh
> index 1b0f82f..b05ca26 100755
> --- a/t/t1402-check-ref-format.sh
> +++ b/t/t1402-check-ref-format.sh
> @@ -18,6 +18,10 @@ invalid_ref 'foo'
>  valid_ref 'foo/bar/baz'
>  valid_ref 'refs///heads/foo'
>  invalid_ref 'heads/foo/'

> +invalid_ref '/foo'
> +invalid_ref '/foo/bar'

As refs///heads/foo is defined to be valid_ref, I am moderately against this change, which can break existing scripts.

> +invalid_ref 'foo/'
> +invalid_ref 'foo/bar/'

We already check trailing slash in existing checks, so I do not see a point in these two additional lines.

>  invalid_ref './foo'
>  invalid_ref '.refs/foo'
>  invalid_ref 'heads/foo..bar'

I was about to write "other than that the patch looks good", but then realized there is nothing remaining after rejecting the new "now slash cannot come at the beginning".