git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: accept trailing "/" in $project_list

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 4, 2012, 17:51 UTC
Message-ID
<7v39bvqru5.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1325671665-16847-1-git-send-email-Matthieu.Moy@imag.fr>
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
Show 18 quoted lines
> The current code is removing the trailing "/", but computing the string
> length on the previous value, i.e. with the trailing "/". Later in the
> code, we do
>
>   my $path = substr($File::Find::name, $pfxlen + 1);
>
> And the "$pfxlen + 1" is supposed to mean "the length of the prefix, plus
> 1 for the / separating the prefix and the path", but with an incorrect
> $pfxlen, this basically eats the first character of the path, and yields
> "404 - No projects found".
>
> While we're there, also fix $pfxdepth to use $dir, although a change of 1
> in the depth shouldn't really matter.
>
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
> I'm not fluent in Perl, and not familiar at all with gitweb, but this
> sounds a rather obvious (too obvious?) fix.

Yeah, probably not many people use $project_maxdepth with a meaningful value.

Previous: Matthieu Moy
Message 2 of 2 in “gitweb: accept trailing "/" in $project_list”
  1. gitweb: accept trailing "/" in $project_listMatthieu Moy, Jan 4, 2012
  2. Junio C HamanoJan 4, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.