From: Junio C Hamano Date: Wed, 04 Jan 2012 17:51:14 GMT Subject: Re: [PATCH] gitweb: accept trailing "/" in $project_list Message-ID: <7v39bvqru5.fsf@alter.siamese.dyndns.org> In-Reply-To: <1325671665-16847-1-git-send-email-Matthieu.Moy@imag.fr> Matthieu Moy writes: > The current code is removing the trailing "/", but computing the string > length on the previous value, i.e. with the trailing "/". Later in the > code, we do > > my $path = substr($File::Find::name, $pfxlen + 1); > > And the "$pfxlen + 1" is supposed to mean "the length of the prefix, plus > 1 for the / separating the prefix and the path", but with an incorrect > $pfxlen, this basically eats the first character of the path, and yields > "404 - No projects found". > > While we're there, also fix $pfxdepth to use $dir, although a change of 1 > in the depth shouldn't really matter. > > Signed-off-by: Matthieu Moy > --- > I'm not fluent in Perl, and not familiar at all with gitweb, but this > sounds a rather obvious (too obvious?) fix. Yeah, probably not many people use $project_maxdepth with a meaningful value.