Re: [PATCH] make __git_ps1 accept a third parameter in pcmode

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 26, 2012, 20:54 UTC
Message-ID: <7v38yso7om.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vfw2so8q3.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> But as I said, there probably is a reason why that approach does not
> work, that is why I said...
>
>>> I have a feeling that I am missing something major, though...

In any case, this was more like "if we were doing this from scratch" conversation.

I think PROMPT_COMMAND mode that takes <pre> and <post> string has been advertised throughout the pre-release freeze, which is long enough in Git timescale to avoid backward incompatibility, so we are already stuck with the function in two modes even if what I said in the previous message (i.e. "why not just one mode") worked.

I am considering to fast-track the "optional third parameter" patch to the 1.8.1 final, so that we can have the same degree of customizability in both modes.

Thanks.