Re: git-prompt.sh vs leading white space in __git_ps1()::printf_format

From: Simon Oosthoek <s.oosthoek@xs4all.nl>
Date: Nov 28, 2012, 20:08 UTC
Message-ID: <50B66F41.1030305@xs4all.nl>
In-Reply-To: <CAA01CspHAHN7se2oJ2WgcmpuRfoa+9Sx9sUvaPEmQ-Y+kDwHhA@mail.gmail.com>

On 28/11/12 19:02, Piotr Krukowiecki wrote:

Show 20 quoted lines

>     Is your setting?:
>     PROMPT_COMMAND=__git_ps1
> 
> 
> That's right
>  
> 
>     I believe you need to give 2 parameters in order to use it in
>     PROMPT_COMMAND mode.
> 
> 
> Are you sure? git-prompt.sh says:
> 
> #    3a) In ~/.bashrc set PROMPT_COMMAND=__git_ps1
> #        To customize the prompt, provide start/end arguments
> #        PROMPT_COMMAND='__git_ps1 "\u@\h:\w" "\\\$ "'
> 
> I interpret this as: if you don't want to customize the prompt, the
> simple "PROMPT_COMMAND=__git_ps1" is enough.
>

I'm sure, although you're right this documentation is wrong... I guess it must have slipped by when the final changes were made to the code. (The requirement to have 2 arguments for PROMPT_COMMAND mode were one of the last changes before being accepted into the release process.)

I've been too busy with other stuff to take another look at this in the meantime.

perhaps the point should read like this: # 3a) In ~/.bashrc set PROMPT_COMMAND # To customize the prompt, provide start/end arguments # PROMPT_COMMAND='__git_ps1 "\u@\h:\w" "\\\$ "'

Which would not be confusing at all, I think...

Show 8 quoted lines

> 
> 
>     These last 2 lines say: if 2 arguments are given, use pcmode.
>     Otherwise you get command-subtitution mode, which gives weird
>     effects when being called from PROMPT_COMMAND.
> 
> 
> Still, it seems to work with above "patch"..

It only works in your specific case, since you're expecting the branch info before the rest of your prompt. The output comes from the part of the code that is meant for substitution mode ;-)

Cheers

Simon