Re: [PATCH] remove protocol from gravatar and picon links for clear if Gitweb is being called through a secure server

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2013, 23:08 UTC
Message-ID: <7v38xkvrbc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAJjU7bQtgaV1XBeeGnuwtz8m3bDtmRYxQE-QasWkoGHNb_NPjQ@mail.gmail.com>

Андрей Баранов  <admin@andrej-andb.ru> writes:

Show 5 quoted lines

> Or maybe option like:
> /etc/gitweb.conf:
> $feature{'ssl'}{'default'} = ['allways']; ['auto']; ['none'];
>
> but it's hard for me :) i don't know perl

The effect is the same and your original patch is shorter and cleaner to see what is going on; as far as the patch text is concerned, the original one is just fine.

Except that we wanted a bit more stuff before "---" line. How about something like this?

        Subject: [PATCH] gitweb: refer to picon/gravatar images over the same scheme

        The images from picon and gravatar are always used over
        http://, and browsers give mixed contents warning when
        gitweb is served over https://.

        Just drop the scheme: part from the URL, so that these
        external sites are accessed over https:// in such a case.

        Signed-off-by: Your Name <your@addre.ss>
        ---
         gitweb/gitweb.perl | 4 ++--
         1 file changed, 2 insertions(+), 2 deletions(-)

        diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
	...