Re: [PATCH] remove protocol from gravatar and picon links for clear if Gitweb is being called through a secure server

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 28, 2013, 22:10 UTC
Message-ID: <20130128221026.GE7759@google.com>
In-Reply-To: <7vfw1lug6f.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

>> Andrej Andb wrote:

Show 8 quoted lines

>>> --- a/gitweb/gitweb.perl
>>> +++ b/gitweb/gitweb.perl
>>> @@ -2068,7 +2068,7 @@ sub picon_url {
>>>  	if (!$avatar_cache{$email}) {
>>>  		my ($user, $domain) = split('@', $email);
>>>  		$avatar_cache{$email} =
>>> -			"http://www.cs.indiana.edu/cgi-pub/kinzler/piconsearch.cgi/" .
>>> +			"//www.cs.indiana.edu/cgi-pub/kinzler/piconsearch.cgi/" .

[...]

> Intuitively it feels strange that the above lets the site that gave
> you the base URL dictate over what scheme sites unrelated to it has
> to serve their resources.

The main effect is to slightly improve privacy. A man in the middle can still see the size of avatars and when you fetched them, but at least this way when you are using HTTPS they do not see the names of authors of commits you are looking at.

It also avoids a mixed content warning.

On the other hand, it hurts caching by proxies.

Jonathan