Re: What to expect after 0.99.8

From: Junio C Hamano <junkio@cox.net>
Date: Oct 3, 2005, 22:06 UTC
Message-ID: <7v1x32l0gz.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0510031709360.23242@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

> The code in ssh-fetch already does parallel fetching, actually (only over 
> one connection, but requests are sent before responses are read), so 
> multiple requests are in progress at the same time.

This reminds me of one patch:

    From: Dan Aloni <da-x@monatomic.org>
    Subject: [PATCH] Fix git+ssh's indefinite halts during long fetches
    Date: Sat, 1 Oct 2005 21:39:42 +0300
    Message-ID: <20051001183942.GA2099@localdomain>

I'd appreciate it if you had a chance to take a look at it and comment on it.

The change is isolated to ssh-fetch [*1*], so even if it were to break something it would only break ssh-fetch and in that sense it is a safer change.

But it still is a lot of code, and I felt there might be a simpler way to do this. That is why I am deliberately holding it off.

[Footnote]

*1* The patch touches sha1_file.c and cache.h but that is to update write_sha1_from_fd(), which is used only by ssh-fetch AFAICT. We may want to move it from sha1_file.c to sha1-fetch.c and make it static, removing it from cache.h.