Re: What to expect after 0.99.8

From: Dan Aloni <da-x@monatomic.org>
Date: Oct 4, 2005, 07:12 UTC
Message-ID: <20051004071210.GA18716@localdomain>
In-Reply-To: <Pine.LNX.4.64.0510031606550.31407@g5.osdl.org>

On Mon, Oct 03, 2005 at 04:16:27PM -0700, Linus Torvalds wrote:

Show 18 quoted lines

> 
> 
> On Mon, 3 Oct 2005, Junio C Hamano wrote:
> > 
> > This reminds me of one patch:
> > 
> >     From: Dan Aloni <da-x@monatomic.org>
> >     Subject: [PATCH] Fix git+ssh's indefinite halts during long fetches
> >     Date: Sat, 1 Oct 2005 21:39:42 +0300
> >     Message-ID: <20051001183942.GA2099@localdomain>
> > 
> > I'd appreciate it if you had a chance to take a look at it and
> > comment on it.
> 
> I personally hate it.
> 
> It adds horrible patches to fairly core stuff, all because the prefetching 
> is not limited.

Well it can be reworked to be more clean...

> As far as I can tell, it should be much easier to just limit the 
> prefetching to some reasonable limit (say, a few objects deep), which 
> guarantees that the prefetching doesn't fill up the write queues on the 
> fetching side.

I'm not sure how this will be completely reliable, even if you limit the prefetching to one object.

Suppose that this one object's size is larger than the receiving queues of the receiving end (like 1 MB?) and the bandwidth is high, wouldn't that break?

-- 
Dan Aloni
da-x@monatomic.org, da-x@colinux.org, da-x@gmx.net