Re: maybe breakage with latest git-pull and http protocol

From: Junio C Hamano <junkio@cox.net>
Date: Oct 15, 2005, 16:22 UTC
Message-ID: <7v1x2mpx6m.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vd5m6py11.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 18 quoted lines

> merlyn@stonehenge.com (Randal L. Schwartz) writes:
>
>> OK, it happened this morning.  While syncing to update from
>> yesterday's version, I got:
>
> Thanks.
>
>>     localhost:~/MIRROR/git-GIT % git-pull
>>     Fetching refs/heads/master from http://www.kernel.org/pub/scm/git/git.git using http
>>     Getting alternates list
>>     got 4546738b58a0134eef154231b07d60fc174d56e3
>>     walk 4546738b58a0134eef154231b07d60fc174d56e3
>>     got d402d5566fdf226697a386dfb9858e5d954e9b91
>>     got 873d8e5652c06c3891278f33546c437efc209c2d
>>     walk d402d5566fdf226697a386dfb9858e5d954e9b91
>>     error: 
>>     Getting pack list
>>     got 0207ab18a3876249a928e7539d8f594a4f6921f1

More interesting is this "error:" without error message. "Getting pack list" is a signal that we fell back to fetch_pack(), so this is coming from fetch_object().

I see this line could emit an empty error message, if errorstr is empty.

	if (request->curl_result != CURLE_OK && request->http_code != 416) {
		ret = error("%s", request->errorstr);
		release_request(request);
		return ret;
	}

So if that is the case maybe my previous speculation that we sometimes forget to issue a necessary request was wrong. We asked for that object and got an error from cURL library...

BTW, I do not think this is related to git.git repository problem, but I wonder why we do not do fetch_object() against each altbase in http-fetch.c::fetch(); nobody said you cannot borrow unpacked object from your neighbour.