Re: maybe breakage with latest git-pull and http protocol

From: Nick Hengeveld <nickh@reactrix.com>
Date: Oct 15, 2005, 21:21 UTC
Message-ID: <20051015212154.GB5509@reactrix.com>
In-Reply-To: <7v1x2mpx6m.fsf@assigned-by-dhcp.cox.net>

On Sat, Oct 15, 2005 at 09:22:25AM -0700, Junio C Hamano wrote:

> More interesting is this "error:" without error message.
> "Getting pack list" is a signal that we fell back to
> fetch_pack(), so this is coming from fetch_object().

I've seen that happen before fetch_pack used the active queue; open object requests in the active queue would not be processed while fetch_pack was transferring the pack, and in some cases a server had timed out a connection from one of these requests by the time the active queue started processing again. I worked around this at one point by detecting an empty server response and retrying the request.

Changing all requests to run through the active queue seemed to fix the problem, but it's possible that something is still holding up processing long enough to cause a server timeout.

> BTW, I do not think this is related to git.git repository
> problem, but I wonder why we do not do fetch_object() against
> each altbase in http-fetch.c::fetch(); nobody said you cannot
> borrow unpacked object from your neighbour.

It doesn't look like there are any alternates defined in the git.git repository. I've seen alternates used during testing when I deliberately removed objects and packs from the primary repository.

-- 
For a successful technology, reality must take precedence over public
relations, for nature cannot be fooled.