Re: [PATCH 4/4] git-daemon support for user-relative paths.

From: Junio C Hamano <junkio@cox.net>
Date: Nov 2, 2005, 09:30 UTC
Message-ID: <7v1x1zv1ln.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <4368760E.6030208@op5.se>

Andreas Ericsson <ae@op5.se> writes:

Show 7 quoted lines

> Junio C Hamano wrote:
>>> -static int log_syslog;
>>>+static int log_syslog = 0;
>> I'd drop this.
>
> No can do. It has to be set either here or down in main. It's nice to 
> have the default in the declaration.

Isn't "static int log_syslog" in BSS to be initialized to zero anyway?

Show 5 quoted lines

>> I like the general direction this set is taking, but let's let
>> it simmer for a while.
>
> Ok. I'll take that to mean "hold off on the --server-root and --userdir 
> patch for a while" then.

I do not mind keeping it in the proposed updates branch for people to see and experiment with, but not in the master branch, at least for now.