Re: [PATCH 4/4] git-daemon support for user-relative paths.

From: Andreas Ericsson <ae@op5.se>
Date: Nov 2, 2005, 09:39 UTC
Message-ID: <43688943.4010002@op5.se>
In-Reply-To: <7v1x1zv1ln.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 16 quoted lines

> Andreas Ericsson <ae@op5.se> writes:
> 
> 
>>Junio C Hamano wrote:
>>
>>>>-static int log_syslog;
>>>>+static int log_syslog = 0;
>>>
>>>I'd drop this.
>>
>>No can do. It has to be set either here or down in main. It's nice to 
>>have the default in the declaration.
> 
> 
> Isn't "static int log_syslog" in BSS to be initialized to zero anyway?
>

I would have thought so, but it wasn't when I tested it. This could be a compiler-bug in my end, I suppose, but spelling it out enhances readability and leaves no room for doubt which is always nice.

Show 9 quoted lines

>>
>>Ok. I'll take that to mean "hold off on the --server-root and --userdir 
>>patch for a while" then.
> 
> 
> I do not mind keeping it in the proposed updates branch for
> people to see and experiment with, but not in the master branch,
> at least for now.
>

I'll cook it up then.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231