Re: [PATCH] Remove unnecessary ouput from t3600-rm.
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 29, 2006, 07:27 UTC
- Message-ID
- <7v1wud9tq0.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060529071646.GC6061@spearce.org>
Shawn Pearce <spearce@spearce.org> writes:
> Moved the output of the setup commits and the test-file rm check to > file descriptors 3 and 4 hiding their messages unless -v is given. > This makes the test suite look a little cleaner when the rm test-file > setup step fails (and was probably expected to fail).
I suspect those bare commands _should_ succeed so make them a separate test step and verify their success return while you are at it, and their output would not be shown normally, without your futzing with file descriptors. Wouldn't that be a lot cleaner approach?