[PATCH] Remove unnecessary ouput from t3600-rm.

Shawn Pearce· May 29, 2006, 07:16 UTC · lore

Moved the output of the setup commits and the test-file rm check to file descriptors 3 and 4 hiding their messages unless -v is given. This makes the test suite look a little cleaner when the rm test-file setup step fails (and was probably expected to fail).

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 t/t3600-rm.sh |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Show changes to t/t3600-rm.sh +3 −3

diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh
index acaa4d6..5b6bf61 100755
--- a/t/t3600-rm.sh
+++ b/t/t3600-rm.sh
@@ -10,14 +10,14 @@ test_description='Test of the various op
 # Setup some files to be removed, some with funny characters
 touch -- foo bar baz 'space embedded' -q
 git-add -- foo bar baz 'space embedded' -q
-git-commit -m "add normal files"
+git-commit -m "add normal files" >&3 2>&4
 test_tabs=y
 if touch -- 'tab	embedded' 'newline
 embedded'
 then
 git-add -- 'tab	embedded' 'newline
 embedded'
-git-commit -m "add files with tabs and newlines"
+git-commit -m "add files with tabs and newlines" >&3 2>&4
 else
     say 'Your filesystem does not allow tabs in filenames.'
     test_tabs=n
@@ -28,7 +28,7 @@ # git-rm barfs, but if the test is run a
 # arranged.
 : >test-file
 chmod a-w .
-rm -f test-file
+rm -f test-file >&3 2>&4
 test -f test-file && test_failed_remove=y
 chmod 775 .
 rm -f test-file

-- 
1.3.3.g45d8

Junio C Hamano· May 29, 2006, 07:27 UTC · re: Shawn Pearce · lore

Re: [PATCH] Remove unnecessary ouput from t3600-rm.

Shawn Pearce <spearce@spearce.org> writes:

> Moved the output of the setup commits and the test-file rm check to
> file descriptors 3 and 4 hiding their messages unless -v is given.
> This makes the test suite look a little cleaner when the rm test-file
> setup step fails (and was probably expected to fail).

I suspect those bare commands _should_ succeed so make them a separate test step and verify their success return while you are at it, and their output would not be shown normally, without your futzing with file descriptors. Wouldn't that be a lot cleaner approach?

Shawn Pearce· May 29, 2006, 08:06 UTC · re: Junio C Hamano · lore

Re: [PATCH] Remove unnecessary ouput from t3600-rm.

Junio C Hamano <junkio@cox.net> wrote:

Show 12 quoted lines

> Shawn Pearce <spearce@spearce.org> writes:
> 
> > Moved the output of the setup commits and the test-file rm check to
> > file descriptors 3 and 4 hiding their messages unless -v is given.
> > This makes the test suite look a little cleaner when the rm test-file
> > setup step fails (and was probably expected to fail).
> 
> I suspect those bare commands _should_ succeed so make them a
> separate test step and verify their success return while you are
> at it, and their output would not be shown normally, without
> your futzing with file descriptors.  Wouldn't that be a lot
> cleaner approach?

Yes.  :-)

--> - Remove unnecessary output from t3600-rm.

Moved the setup commands into test_expect_success blocks so their output is hidden unless -v is used. This makes the test suite look a little cleaner when the rm test-file setup step fails (and was expected to fail for most cases).

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 t/t3600-rm.sh |   42 +++++++++++++++++++++++-------------------
 1 files changed, 23 insertions(+), 19 deletions(-)

Show changes to t/t3600-rm.sh +23 −19

diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh
index acaa4d6..201d164 100755
--- a/t/t3600-rm.sh
+++ b/t/t3600-rm.sh
@@ -8,30 +8,34 @@ test_description='Test of the various op
 . ./test-lib.sh
 
 # Setup some files to be removed, some with funny characters
-touch -- foo bar baz 'space embedded' -q
-git-add -- foo bar baz 'space embedded' -q
-git-commit -m "add normal files"
-test_tabs=y
-if touch -- 'tab	embedded' 'newline
-embedded'
-then
-git-add -- 'tab	embedded' 'newline
+test_expect_success \
+    'Initialize test directory' \
+    "touch -- foo bar baz 'space embedded' -q &&
+     git-add -- foo bar baz 'space embedded' -q &&
+     git-commit -m 'add normal files' &&
+     test_tabs=y &&
+     if touch -- 'tab	embedded' 'newline
 embedded'
-git-commit -m "add files with tabs and newlines"
-else
-    say 'Your filesystem does not allow tabs in filenames.'
-    test_tabs=n
-fi
+     then
+     git-add -- 'tab	embedded' 'newline
+embedded' &&
+     git-commit -m 'add files with tabs and newlines'
+     else
+         say 'Your filesystem does not allow tabs in filenames.'
+         test_tabs=n
+     fi"
 
 # Later we will try removing an unremovable path to make sure
 # git-rm barfs, but if the test is run as root that cannot be
 # arranged.
-: >test-file
-chmod a-w .
-rm -f test-file
-test -f test-file && test_failed_remove=y
-chmod 775 .
-rm -f test-file
+test_expect_success \
+    'Determine rm behavior' \
+    ': >test-file
+     chmod a-w .
+     rm -f test-file
+     test -f test-file && test_failed_remove=y
+     chmod 775 .
+     rm -f test-file'
 
 test_expect_success \
     'Pre-check that foo exists and is in index before git-rm foo' \

-- 
1.3.3.g45d8

patchRemove unnecessary ouput from t3600-rm.