Re: [PATCH] Fix Solaris compiler warnings

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 15, 2007, 23:16 UTC
Message-ID: <7v1war3xrq.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071115230002.GA24069@steel.home>

Alex Riesen <raa.lkml@gmail.com> writes:

Show 14 quoted lines

> Guido Ostkamp, Thu, Nov 15, 2007 23:19:11 +0100:
>> Hello,
>>
>> the below patch fixes some compiler warnings returned by Solaris Workshop 
>> Compilers.
>>
>>     CC builtin-apply.o
>> "builtin-apply.c", line 686: warning: statement not reached
>>     CC utf8.o
>> "utf8.c", line 287: warning: statement not reached
>>     CC xdiff/xdiffi.o
>> "xdiff/xdiffi.c", line 261: warning: statement not reached
>
> All these are wrong. That's a fantastically broken piece of compiler

Eh?

I've looked at builtin-apply and utf8 cases but these returns are after an endless loop whose exit paths always return directly, so these return statements are in fact never reached.

Dumber compilers may not notice and if you remove these returns they may start complaining, though.