Re: [PATCH] Rewrite some function exit paths to avoid "unreachable code" traps

From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Nov 17, 2007, 14:31 UTC
Message-ID: <200711171531.09545.robin.rosenberg.lists@dewire.com>
In-Reply-To: <20071117122317.GA2716@steel.home>

lördag 17 november 2007 skrev Alex Riesen:

Show 22 quoted lines

> Robin Rosenberg, Sat, Nov 17, 2007 11:39:32 +0100:
> > lördag 17 november 2007 skrev Alex Riesen:
> > > Noticed by Guido Ostkamp for Sun's Workshop cc.
> > > 
> > > Originally-by: Guido Ostkamp <git@ostkamp.fastmail.fm>
> > > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> > > ---
> > > Guido Ostkamp, Fri, Nov 16, 2007 23:52:01 +0100:
> > > >
> > > > What about the xdiff/xdiffi.c problem that should also be solved?
> > > >
> > > 
> > 
> > Please... This just looks bad. I'm sure we'll have fixup patches on the list
> > to fix those gotos. 
> > 
> > Do we support any such stupid compiler that requires a dummy goto?
> 
> It is more for the compilers we don't know about yet.
> 
> Userspace programming, especially with intent to be portable, often
> means supporting *bugs* of the platform where it happens.

*If* it happens. We do not workaround every hypothetical compiler bug or every hypotetical buggy compiler. Compilers we don't know about does not "exist", expect for the perfectly confirming ones, but they aren't buggy.

It seems the return in utf8.c was introduced by mistake and Junio has made his decision now.

-- robin