Re: [PATCH] Don't use the pager when running "git diff --check"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 14, 2007, 20:54 UTC
- Message-ID
- <7v1w9pq9o9.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <26AEA0A9-9F15-4245-9D27-61050DA57E6F@wincent.com>
Wincent Colaiuta <win@wincent.com> writes:
Show 7 quoted lines
> El 14/12/2007, a las 6:11, Junio C Hamano escribió: > >> You are right. While I do not personally miss paging output, it is a >> regression not to page --check output by default. > > I thought this was ok because "git diff --exit-code" also produces > useful output and also turns off the pager.
It is different. --exit-code was that way from day one. The primary use of --check has been (and I suspect it will continue to be) for people to _view_ the diff, spot problems so that they can fix them up, and for that use case, exit code does not matter but pageability does. You are introducing a new behaviour and a new use case --- that does not give you a license to break other existing use cases.