Re: [PATCH] Don't use the pager when running "git diff --check"

From: Jeff King <peff@peff.net>
Date: Dec 14, 2007, 04:51 UTC
Message-ID: <20071214045127.GC10169@sigill.intra.peff.net>
In-Reply-To: <1197575138-58070-1-git-send-email-win@wincent.com>

On Thu, Dec 13, 2007 at 08:45:38PM +0100, Wincent Colaiuta wrote:

> In 89d07f75 "git diff" learnt to not run the pager if the user passes
> the --exit-code switch. This commit does the same for the --check
> switch for the same reason: we want the user to get the exit status
> from "git diff", not the pager.

But --check is also producing useful output, which might need paged. So you are sacrificing existing interactive use of --check for scriptable exit-code uses. If you really want the exit code, why not "git diff --check --exit-code"?

OTOH, I am not too sad to lose the paging behavior; it would take quite a few whitespace errors to scroll off the screen.

-Peff