git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat: Add simplified merge sort implementation from glibc

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 3, 2008, 06:22 UTC
Message-ID
<7v1w7u1ruz.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.LSU.1.00.0802030231080.7372@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 5 quoted lines
> So I would like this to go in, evidently, if only as a starting point for 
> people to play with sorting algorithms, to find the one which is optimal 
> for our general use (we have quite some uses where we put in _almost_ 
> sorted data, which seems to be the worst-case for many sorting 
> algorithms).

I do not think we want to spend arguing over the last few percent to get anything ultra-fast. The aim for compat/ is to have a replacement for unusable platform-supplied stuff.

The patch looked fine, thanks.

If I may add a bikeshed comment, I probably would have modelled the make variable, not after ssl-with-crypto and libiconv, but after {arm,mozilla,ppc}-sha1, if I were naming it. This is not like an absolute must-to-have: "on this platform, libc is not enough and we NEED to explicitly ask for -liconv". It is more like a choose-to-use: "we could use openssl sha1 implementation, but I choose to use Mozilla one".

Previous: Brian DowningNext: Johannes Schindelin
Message 5 of 11 in “compat: Add simplified merge sort implementation from glibc”
  1. compat: Add simplified merge sort implementation from glibcBrian Downing, Feb 3, 2008
  2. Edgar ToernigFeb 4, 2008
  3. Johannes SchindelinFeb 3, 2008
  4. Brian DowningFeb 3, 2008
  5. Junio C HamanoFeb 3, 2008
  6. Johannes SchindelinFeb 3, 2008
  7. Brian DowningFeb 4, 2008
  8. Mike RalphsonFeb 5, 2008
  9. Brian DowningFeb 5, 2008
  10. Junio C HamanoFeb 5, 2008
  11. Brian DowningFeb 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.