From: Junio C Hamano Date: Sun, 03 Feb 2008 06:22:44 GMT Subject: Re: [PATCH] compat: Add simplified merge sort implementation from glibc Message-ID: <7v1w7u1ruz.fsf@gitster.siamese.dyndns.org> In-Reply-To: Johannes Schindelin writes: > So I would like this to go in, evidently, if only as a starting point for > people to play with sorting algorithms, to find the one which is optimal > for our general use (we have quite some uses where we put in _almost_ > sorted data, which seems to be the worst-case for many sorting > algorithms). I do not think we want to spend arguing over the last few percent to get anything ultra-fast. The aim for compat/ is to have a replacement for unusable platform-supplied stuff. The patch looked fine, thanks. If I may add a bikeshed comment, I probably would have modelled the make variable, not after ssl-with-crypto and libiconv, but after {arm,mozilla,ppc}-sha1, if I were naming it. This is not like an absolute must-to-have: "on this platform, libc is not enough and we NEED to explicitly ask for -liconv". It is more like a choose-to-use: "we could use openssl sha1 implementation, but I choose to use Mozilla one".