Re: log --graph --first-parent weirdness

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2008, 18:05 UTC
Message-ID: <7v1w3dxeh9.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080604173820.GA3038@mithlond.arda.local>

Teemu Likonen <tlikonen@iki.fi> writes:

> To me it's perfectly fine to turn off --graph when used with
> --first-parent, but yes, generally users might expect to see a line of
> M's, *'s and |'s there. At least it would clearly show which commits are
> merges and which are not.

I disagree. If you are doing --first-parent, you do not _care_ what is merge and what is not. Besides, you can easily see that from the log message if you cared enough.

And if the graph actually draws the real ancestry graph (i.e. without --first-parent), the lines visually show which is merge and which is not, so the "M" gets very distracting.

I'd really suggest changing the "M" and use "*" everywhere.